Repository navigation
fix(data-grid): distinguish literal string 'NULL' from SQL NULL in TableMutationEngine WHERE clause - #1385
Merged
ZhuchkaTriplesix merged 2 commits intoOct 10, 2026
Conversation
…bleMutationEngine WHERE clause Closes #1368
github-actions
Bot
added
bug
generatePlan passed only columnDataTypes to _buildWhereClause, so callers supplying types via columnMeta got no text-type detection and the literal string 'NULL' was still rendered as IS NULL.
ZhuchkaTriplesix
deleted the
issue/1368-distinguish-null-literal-in-where
branch
October 11, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1368
Summary
TableMutationEngine._buildWhereClause, check if column type is a text column (_isTextType) before treating string'NULL'or'null'as SQLNULL.kNullSentinelto unambiguously identify genuine SQLNULLinrowacross primary key matches and unkeyed fallback matches.'NULL'asWHERE col = 'NULL'in UPDATE and DELETE statements for text columns, preventing accidental corruption or deletion of unintended rows.test/core/database/table_mutation_engine_test.dart.